Skip to content

♻️ refactor project listing DB function (🚨 We no longer list projects that do not have a product assigned) #6692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 11, 2024
Merged

♻️ refactor project listing DB function (🚨 We no longer list projects that do not have a product assigned) #6692

merged 7 commits into from
Nov 11, 2024

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Nov 8, 2024 •
edited
Loading

What do these changes do?

  • ♻️ As part of the project module improvements, I merged the two listing functions in the DB layer into one in this PR.
  • 🚨 Breaking change 🚨 We no longer list projects that do not have a product assigned. (Projects in this situation have their last timestamp changed before 11.11.2022.)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 8, 2024
@codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 14 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (e32787b) to head (75f6aea).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6692      +/-   ##
==========================================
+ Coverage   87.95%   88.88%   +0.93%     
==========================================
  Files        1569     1272     -297     
  Lines       63117    54419    -8698     
  Branches     2106      897    -1209     
==========================================
- Hits        55512    48371    -7141     
+ Misses       7280     5914    -1366     
+ Partials      325      134     -191
Flag Coverage Δ
integrationtests 64.87% <14.28%> (+0.03%) ⬆️
unittests 86.64% <85.71%> (+0.72%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.00% <71.42%> (-0.20%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 71.44% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 97.17% <ø> (ø)
api_server 89.82% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 89.46% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 90.96% <ø> (+0.12%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.79% <ø> (ø)
efs_guardian 90.00% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.15% <ø> (ø)
payments 93.02% <ø> (ø)
resource_usage_tracker 90.75% <ø> (ø)
storage 89.76% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 89.36% <96.42%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32787b...75f6aea. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 8, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 8, 2024 15:04
bisgaard-itis
bisgaard-itis approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks a lot for the effort 😄

sanderegg
sanderegg reviewed Nov 10, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't we missing some tests in here? not sure I get the gist of the scopes.

GitHK
GitHK reviewed Nov 11, 2024
View reviewed changes
@matusdrobuliak66
Copy link
Collaborator Author

matusdrobuliak66 commented Nov 11, 2024 •
edited
Loading

We actually have a lot of listing tests. If they pass, it means nothing was broken. As for the scopes, the idea is to differentiate the type of filtering to apply. For folders, this could mean:

  • Root folder (represented by a null value in the database)
  • Specific folder (represented by an integer) - This is a specific user folder (as folders can not be shared, they are owned exclusively by user) - maybe should I rename this type to USER?
  • ALL folders (searching through all folders)

The same logic applies to workspaces. In the context of workspaces, the types are:

  • PRIVATE (My Workspace - represented by a null value in the database)
  • SHARED (represented by an integer)
  • ALL workspaces

Does this make more sense? We can discuss further offline if needed.

sanderegg
sanderegg approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all clear, thanks for the explanations

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 11, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ refactor project listing DB function ♻️ refactor project listing DB function (:rotating_light: We no longer list projects that do not have a product assigned) Nov 11, 2024
@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ refactor project listing DB function (:rotating_light: We no longer list projects that do not have a product assigned) ♻️ refactor project listing DB function (🚨 We no longer list projects that do not have a product assigned) Nov 11, 2024
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 11, 2024 10:51
@matusdrobuliak66 matusdrobuliak66 merged commit ce9d3a5 into ITISFoundation:master Nov 11, 2024
87 of 89 checks passed
This was referenced Nov 11, 2024
Merged
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 12, 2024
Closed
30 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo giancarloromeo is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

None yet

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

5 participants

@matusdrobuliak66 @GitHK @pcrespov @sanderegg @bisgaard-itis